Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom conf can't overwrite the default conf #647

Closed
jianhaiqing opened this issue Jan 16, 2021 · 1 comment · Fixed by #651
Closed

custom conf can't overwrite the default conf #647

jianhaiqing opened this issue Jan 16, 2021 · 1 comment · Fixed by #651

Comments

@jianhaiqing
Copy link
Contributor

https://github.com/presslabs/mysql-operator/blob/2a95c33f1d7155306e973f2957cc8bd5fffeeeab/pkg/controller/mysqlcluster/internal/syncer/config_map.go#L100

it would nice as follows:

if cluster.GetMySQLSemVer().Major == 5 {
addKVConfigsToSection(sec, convertMapToKVConfig(mysql5xConfigs))
} else if cluster.GetMySQLSemVer().Major == 8 {
addKVConfigsToSection(sec, convertMapToKVConfig(mysql8xConfigs))
}
// common configs
addKVConfigsToSection(sec, convertMapToKVConfig(mysqlCommonConfigs), cluster.Spec.MysqlConf)
@AMecea
Copy link
Contributor

AMecea commented Jan 18, 2021

Hi @jianhaiqing, indeed this should be fixed, please open a PR.

jianhaiqing added a commit to jianhaiqing/mysql-operator that referenced this issue Jan 30, 2021
@jianhaiqing
Fix bitpoke#647 custom conf can't overwrite the default conf
5516212
@jianhaiqing jianhaiqing mentioned this issue Jan 30, 2021
Merged
jianhaiqing added a commit to jianhaiqing/mysql-operator that referenced this issue Feb 4, 2021
@jianhaiqing
Fix bitpoke#647 custom conf can't overwrite the default conf
6c029bd
AMecea pushed a commit that referenced this issue Feb 15, 2021
@jianhaiqing @AMecea
Fix #647 custom conf can't overwrite the default conf
a46cf4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #647 custom conf can't overwrite the default conf jianhaiqing/mysql-operator
2 participants
@AMecea @jianhaiqing