Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete backups from backupBucket when deleting a MysqlBackup #81

Closed
calind opened this issue Jul 17, 2018 · 1 comment
Closed

Delete backups from backupBucket when deleting a MysqlBackup #81

calind opened this issue Jul 17, 2018 · 1 comment
Milestone
0.2.7

Comments

@calind
Copy link
Member

calind commented Jul 17, 2018

No description provided.

@calind calind modified the milestones: Production level, 0.2.0 Jul 17, 2018
@AMecea AMecea modified the milestones: 0.2.x, 0.2.6 Feb 25, 2019
@AMecea
Copy link
Contributor

AMecea commented Mar 4, 2019

Use finalizers to block backup deletion until the backup is deleted from the remote.

Add a .spec.deletePolicy field. For example:

kind: MysqlBackup
spec:
  clusterName: foo
  deletePolicy: hardDelete / softDelete

Log failed deletion attempts in events. Also, it needs an exponential backup deletion retry.

@AMecea AMecea modified the milestones: 0.2.6, 0.2.7 Mar 4, 2019
@AMecea AMecea closed this as completed Mar 21, 2019
chapsuk pushed a commit to chapsuk/mysql-operator that referenced this issue Oct 16, 2023
@PrismaPhonic
Update Strategy (bitpoke#81)
f25c552 
* Added a new field to choose a specific update strategy for vtop.

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>

* Added the update strategy field to the VitessKeyspaceSpec per our plan with a comment that this gets inherited. Ran the defaulting code when defaulting VitessKeyspaceSpec because we don't have a garauntee that the parent PSC defaulting code has run yet.

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>

* Make sure this gets written on down.

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>

* Make generate after updating VitessKeyspaceSpec to have the inherited field.

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>

* Ran go mod tidy.

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>

* Checked out mod and sum from master because go mod tidy is breaking builds.

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>

* Update doc comments pre review suggestions.

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>

* Added updates to all immediate children of VitessCell and VitessKeypsace to use UpdateInPlace handler instead of UpdateRollingInPlace

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>

* Added a new custom condition type to represent that updates have been scheduled for children of the shard.

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>

* Added logic to update lowest observed shard generation by pods.

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>

* Got rid of condition type now that we are using a different approach involving generations. Also added a new status field of lowest observed shard generation by all child pods.

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>

* Added logic for cascading changes if generations match, and we have pending changes.

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>

* This is a bit cleaner to remove nesting by bailing earlier if defaulting code hasn't been run yet, preventing safe access into pointer types.

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>

* Need to add this back in case immediate is not set.

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>

* Re-ran make generate.

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>

* Comment update per review suggestion.

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>

* Remove nil checks for readability since we know we will have run defaulting code before these get called.

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>

* New line should not be capitalized for same sentence.

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>

* Unindent less trivial case for readability.

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>

* Make sure we allocate a map if it's nil at this point.

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>

* Junk removal.

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>

* Added check that if update strategy is immediate, vtctld changes rollout immediately.

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>

* Re-ran make generate.

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
usernameisnull pushed a commit to usernameisnull/mysql-operator that referenced this issue Mar 3, 2024
@marinesovitch
CI: remove some noise from logs
8cd2302 
in some places, we listed processed files (with shell 'ls' or 'tar' with flag -v)
that info was useful in the past when jobs/pipelines were under construction
today, it is only noise without much value

besides, as the amount of diagnostics and number of configurations for the weekly grow
there are more and more files in the build artifact
for weekly bitpoke#81 it caused jenkins failure while gathering results when all result
files were meant to list with 'ls -lRF'

Change-Id: I9b31d43eaa8e41261d7267dc160c1d2c063fe958
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.7
Development

No branches or pull requests
2 participants
@calind @AMecea