Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubebuilder pvc cleanup #133

Closed
wants to merge 64 commits into from
Closed

Kubebuilder pvc cleanup #133

wants to merge 64 commits into from

Conversation

smanpathak
Copy link
Contributor

Use new kubebuilder style reconcile functions to cleanup pending PVCs. Alternative to #125

  1. Adds new Pvc cleanup controller to watch pvc events in K8s
  2. CleanupGracePeriod option to keep PVCs around till grace period expires
  3. Uses finalizer to prevent Pvc deletion for CleanupGracePeriod

AMecea and others added 30 commits August 16, 2018 14:29
@AMecea
Update vendor for kubebuilder.
b35c9b7
@AMecea
Cleanup for kubebuilder.
00b22ea
@AMecea
Add backups types.go
4a1ea43
@AMecea
Fix types unittests.
04e27da
@AMecea
Run tests on drone.
0e92dd3
@AMecea
Add mysqlcluster controller.
0251bf3
@AMecea
Update vendor for mysql cluster.
f97fa4d
@AMecea
Move logic from apis to wrappers.
af783fc
@MerceaOtniel @AMecea
Code Review
a1b34e8 
Fix some errors
Modify set defaults
Modify package name to syncer
Modify tests for better readability
Rename package and fix some build problems in tests
Wait for the expected reconcile request in beforeEach
Replace gas with gosec
@AMecea
Update vendor to kubernetes 1.11
97feafd
@AMecea
Add golangci-lint linter.
049a264
@AMecea
Use kubernetes defaults, fix tests, fix linting, rename stoppkg -> st…
da9e1a5 
…op, remove glog.
@MerceaOtniel @AMecea
Upgrade drone to 1.11
fba1c39
@AMecea
Make status subresource.
037c417
@AMecea
Move wrappers and syncer to controller/internal.
a3dc537
@AMecea
Create a util/constants package with constants.
82fe4ec
@AMecea
Move pakcages. Update kubebuilder to v1.0.4
76a934b
@AMecea
Update Gopkg.toml
70a3a79
@MerceaOtniel
Modify sync function
5d48310
@MerceaOtniel
Implement the interface
2b9de80
@MerceaOtniel
Add vendor file
f214611
@MerceaOtniel
Fix compile and linting problems
1ba0d7d
@AMecea @calind
Add orchestrator-mysql controller.
b9cbe87
@AMecea @calind
Add orchestartor to mysql controller syncer.
3de59ae
@AMecea @calind
Make cluster read only.
1b67c38
@AMecea @calind
Rename orchestrator controller. Use sync.Map. Use wrappers.
2d43456
@AMecea @calind
Fix linting.
a582861
@AMecea @calind
Update cluster, fix tests.
8ace4ee
@AMecea @calind
Refactor orchestrator reconciler, and tests.
bc941d9
@AMecea @calind
Add test for orc register/unregister nodes.
d2bc2e4
calind and others added 26 commits September 21, 2018 15:58
@calind
Refactor orchestrator controller tests
e603918
@calind
Add orchestrator controller to manager
25331c1
@calind
Use stop.Channel in main entry point
415cd3e
@calind
Split test stages on drone
eb5785c
@AMecea @calind
Code review.
01a5423
@AMecea
Check for an extra reconcile event in tests.
b0cb49b
@AMecea @calind
Add mysql-operator-sidecar.
937f27f
@AMecea @calind
Add mysql driver dependency.
de0a12f
@AMecea @calind
Fix constants import. And update Makefile.
ba70dcb
@AMecea @calind
Fix linting and remove glog.
0c1c634
@AMecea @calind
Move from cmd to pkg/sidecar
6150ff0
@AMecea @calind
Use SetupSignalHandler from controller-runtime package.
d5ae8c0
@AMecea @calind
Add a finalizer syncer.
3a6412a
@AMecea @calind
Add finalizer test.
ad707d7
@AMecea @calind
Use a runnablefunc to dispatch events.
e4e7c6e
@AMecea
Add pod label syncer.
ef09d01
@AMecea
Add tests for pod label syncer.
59dc789
@AMecea
Add chart.
b273a2d
@AMecea
Add chart generate make tag.
05a25ef
@AMecea
Make operator to work with the chart.
711cc28
@AMecea
Fix query issues
f5eba23
@AMecea
Use mysql placeholder for queries.
5a46fe8
@AMecea
Use yq to update the chart.
ee7221e
@AMecea
Fix placeholder in queryes for tables names.
9668a5d
@smanpathak @AMecea
Fix spelling, add makefile targets
6707586
@smanpathak
Add PVC cleanup: Using finalizers
6222b43
@smanpathak smanpathak closed this Oct 17, 2018
@smanpathak smanpathak deleted the kubebuilder-pvc-cleanup branch October 17, 2018 21:28
@smanpathak smanpathak restored the kubebuilder-pvc-cleanup branch October 17, 2018 21:28
chapsuk pushed a commit to chapsuk/mysql-operator that referenced this pull request Oct 16, 2023
@PrismaPhonic @enisoc
Remove servingShards. This is never correct during horizontal reshard…
5653c92 
…ing. We can just rely on sourceShards. (bitpoke#133)

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smanpathak @AMecea @MerceaOtniel @calind