Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let operator set master writable and set cluster ready only when it's healty #222

Merged
merged 6 commits into from
Feb 11, 2019
Merged

Let operator set master writable and set cluster ready only when it's healty #222

merged 6 commits into from
Feb 11, 2019

Conversation

AMecea
Copy link
Contributor

@AMecea AMecea commented Feb 8, 2019 •
edited
Loading

fixes #199

@AMecea AMecea changed the title No master promotion Let operator set master writable and set cluster ready only when it's healty Feb 8, 2019
@AMecea AMecea added this to the 0.2.4 milestone Feb 11, 2019
calind
calind requested changes Feb 11, 2019
View reviewed changes
pkg/controller/internal/testutil/cluster.go Show resolved Hide resolved
pkg/controller/mysqlcluster/internal/syncer/settings.go Outdated Show resolved Hide resolved
pkg/util/constants/constants.go Outdated Show resolved Hide resolved
pkg/controller/orchestrator/orchestrator_reconcile.go Outdated Show resolved Hide resolved
pkg/controller/orchestrator/orchestrator_reconcile.go Outdated Show resolved Hide resolved
@calind calind merged commit af9ba15 into master Feb 11, 2019
@AMecea AMecea deleted the no-master-promotion branch March 21, 2019 15:57
@AMecea AMecea mentioned this pull request Nov 3, 2020
Closed
chapsuk pushed a commit to chapsuk/mysql-operator that referenced this pull request Oct 16, 2023
Reconcile vtbackup PVCs like vttablet (bitpoke#222)
958e432 
In order for dynamic local storage provisioners to influence pod
scheduling for future PV creation, ensure the vtbackup data PVC exists
before the Pod.

This matches the order in reconcile_tablets.go.

Decouple the orphan Pod detection for pods of all phases (Pending,
Running, Succeeded, Failed, Unknown). Ensure that temporary node
failures marking pods as Failed do not inadvertently delete PVCs until
reconciling a termination of the Pod.

Fixes: bitpoke#221

Signed-off-by: Sean Treadway <sean@soundcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calind calind calind requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.4
Development

Successfully merging this pull request may close these issues.

Let the operator set the master writable
2 participants
@AMecea @calind