Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit backup job name to 63 chars, fix #836 #837

Merged
merged 1 commit into from
Aug 27, 2022

Conversation

w33dw0r7d
Copy link
Contributor

closes/fixes #836

@w33dw0r7d w33dw0r7d changed the title Limit backup job name to 63 chars, fix #863 Limit backup job name to 63 chars, fix #836 Aug 8, 2022
@w33dw0r7d w33dw0r7d force-pushed the limit-backup-job-name branch from c98ca0e to 54910b8 Compare August 8, 2022 09:54
@w33dw0r7d
Copy link
Contributor Author

@cndoit18 review please.

Copy link
Collaborator

@cndoit18 cndoit18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution, add some unit tests, plz.

@w33dw0r7d w33dw0r7d force-pushed the limit-backup-job-name branch from 54910b8 to 678260c Compare August 11, 2022 06:55
@w33dw0r7d
Copy link
Contributor Author

@cndoit18 Thank you for review. Add tests.

@w33dw0r7d
Copy link
Contributor Author

@cndoit18 review please.

@w33dw0r7d
Copy link
Contributor Author

@cndoit18 Merge please.

@cndoit18
Copy link
Collaborator

Hi, squash your commits, plz

@w33dw0r7d w33dw0r7d force-pushed the limit-backup-job-name branch from c494268 to 8294735 Compare August 27, 2022 13:35
@cndoit18 cndoit18 merged commit 8b5fffb into bitpoke:master Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit backup job name to 63 charts
2 participants