-
Notifications
You must be signed in to change notification settings - Fork 148
Conversation
It's required for using Firebase App Distribution. https://firebase.google.com/products/app-distribution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤖 👍
The usual concern with any preinstalled tool is whether they require the latest version of this tool to be available, cause if they do it’s usually not a good idea to preinstall the tool as that’ll only be updated once a week. That said in this case we'll also have a Step for Firebase App Distribution which should be able to handle this case, when a newer version of the tool would be required and update the tool during the step's run. |
According to Firebase CLI docs there is no strong requirement on having the latest version. It's only a good practice. |
@Vrtak-CZ please update the CHANGELOG.md file with the added tool and the version number accordingly in the Dockerfile |
I submitted our usual PR checklist to this repo #260 |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you @Vrtak-CZ ! :)
Also thanks @koral-- for the infos ;) |
It's required for using Firebase App Distribution.
https://firebase.google.com/products/app-distribution
Pull Request Checklist
Check/accept these: