Don't forward merge ref if it's not up to date #125
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
go fmt
on your files (e.g.go fmt ./service/common.go
, or on the wholeservice
folder:go fmt ./service/...
)An example, if you'd write a comment like "Given X this function will return Y" or
"Beware, if the input is X this function will return Y" then you should implement this as
a unit test, instead of writing it as a comment.
README.md
and change/add the descriptions there - alsofeel free to add yourself as a contributor if you implement support for a new service ;)
bitrise run test
with the Bitrise CLI,to perform all the automatic checks (which will run on your Pull Request when you open it).
Summary of Pull Request
The
mergeable
field can betrue
,false
ornull
. When it'snull
, this means the mergeability check is still pending, so using the merge ref in checkouts leads to checking out an outdated state.This PR changes how we create the build params, we should only include the merge ref if we know it's up to date.
GitHub API: https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#get-a-pull-request