Add version as input to Bitrise CLI header #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tothszabi
reviewed
Nov 16, 2022
log/log.go
Outdated
Comment on lines
148
to
150
| if v == "" { | ||
| v = version.VERSION | ||
| } |
There was a problem hiding this comment.
I think we can drop this fallback from here because it is not the logger's responsibility to make sure the version has a non-empty value. It should just log based on the input it has received.
There was a problem hiding this comment.
In that case do we need strings.TrimSpace from line 147?
There was a problem hiding this comment.
Yes, you are right. That can be removed as well.
tothszabi
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the version from the
models.WorkflowRunPlanwhen printing the Bitrise CLI header.