Agent hooks #896
Merged
Agent hooks #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpusok
reviewed
Nov 21, 2023
| return nil | ||
| } | ||
|
|
||
| if os.Getenv(analytics.StepExecutionIDEnvKey) != "" { |
There was a problem hiding this comment.
Does this work with Run bitrise Step too?
There was a problem hiding this comment.
Yes, that's the point of this. Everything running in a scrip step has this env var defined, so the CLI process spawned there will run into this block.
lpusok
reviewed
Nov 21, 2023
cli/agent.go
Outdated
| log.Print() | ||
|
|
||
| cmd := exec.Command(hooks.DoOnBuildStart) | ||
| cmd.Stdout = os.Stdout |
There was a problem hiding this comment.
Logging to stdout could be problematic as it would not be in the JSON log format expected in CI run. It can be omitted or wrapped in additional logging.
There was a problem hiding this comment.
Thank you, good point! Take a look now
lpusok
reviewed
Nov 21, 2023
| type WorkflowRunner struct { | ||
| config RunConfig | ||
| config RunConfig | ||
| agentConfig *configs.AgentConfig |
There was a problem hiding this comment.
Can you document why agentconfig has top be seperate from config for posterity?
lpusok
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
README.mdis updated with the changes (if needed)Version
Requires a MINOR version update
Context
Same theme as #894, but this PR is about running arbitrary commands before and after the CLI picks up a build in agent mode.
Changes
workflowtobuildas these actions are meant to be run in the context of a build, i.e. when an agent picks up a build to execute. One such CLI invocation can result in multiple workflows executed, such asrun_before,run_afterand innerbitrise run workflowcalls.cli/agent.goInvestigation details
Decisions