Tool version telemetry #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
ofalvai
force-pushed
the
BE-1221-tool-version-tracker
branch
4 times, most recently
from
b17de03 to
a0a14c9
Compare
ofalvai
force-pushed
the
BE-1221-tool-version-telemetry
branch
from
0c03dd7 to
abb8e46
Compare
ofalvai
force-pushed
the
BE-1221-tool-version-tracker
branch
from
a0a14c9 to
d8867b9
Compare
tothszabi
previously approved these changes
Dec 20, 2023
ofalvai
force-pushed
the
BE-1221-tool-version-telemetry
branch
from
abb8e46 to
9800c02
Compare
ofalvai
force-pushed
the
BE-1221-tool-version-tracker
branch
from
d8867b9 to
67bc2fe
Compare
tothszabi
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
README.mdis updated with the changes (if needed)Version
Requires a MAJOR/MINOR/PATCH version update
Context
Follow up to #902
Changes
Investigation details
Decisions
As the tool version map contains arbitrary key-value pairs and we'll add more tools under ASDF, I decided to just serialize everything as JSON. We can process the JSON at query-time easily.