Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new Apple certificates listing #114

Merged
merged 2 commits into from
Oct 4, 2019
Merged

Fix new Apple certificates listing #114

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a65cfe
Fix new Apple certificates listing
godrei Oct 4, 2019
ba5f549
PR update
godrei Oct 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions codesign/certificates.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@ var (
"Mac Developer", // type: "Mac Development"
"3rd Party Mac Developer Application", // type: "Mac App Distribution"
"Developer ID Application", // type: "Developer ID Application"
"Apple Development", // type: "iOS Development for Xcode 11", id: "83Q87W3TGH"
Copy link
Contributor

@lpusok lpusok Oct 4, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the ID for?

Copy link
Contributor Author

@godrei godrei Oct 4, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the id of the cert type on the dev portal, but as we do not use them, i will remove that part of the comment.
Other than that previous cert type's comments, showed how the cert appears in Xcode.

"Apple Distribution", // type: "iOS Distribution for Xcode 11", id: "WXV89964HE"
}

macOSInstallerCertificateNames = []string{
"3rd Party Mac Developer Installer", // type: "Mac Installer Distribution"
"Developer ID Installer", // type: "Developer ID Installer"
"Apple Development", // type: "iOS Development for Xcode 11", id: "83Q87W3TGH"
"Apple Distribution", // type: "iOS Distribution for Xcode 11", id: "WXV89964HE"
}
)

Expand Down