-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xcodebuild command destination
flag
#147
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0ed79a0
patch for m1
shams-ahmed b0aa3c0
use ccode
shams-ahmed 6a37109
fixed project link for xcodeproj
shams-ahmed 511f444
added new tests for platform matching
shams-ahmed 39c9b14
remove extra files
shams-ahmed 03ae849
fixed lint
shams-ahmed fcafd8a
Pr comments
shams-ahmed aeac26f
updated text
shams-ahmed bc5ab40
updated text
shams-ahmed d627714
fixed lint
shams-ahmed d32fc77
remove workspace dupe code
shams-ahmed ba9f864
fixed PR comments
shams-ahmed File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
package utility | ||
|
||
import ( | ||
"testing" | ||
|
||
"github.com/bitrise-io/go-xcode/xcodeproject/serialized" | ||
"github.com/stretchr/testify/require" | ||
) | ||
|
||
func TestPlatformsMatching_iOS(t *testing.T) { | ||
buildSettings := serialized.Object{} | ||
buildSettings["SDKROOT"] = "iphoneos" | ||
|
||
platform, err := getPlatform(buildSettings) | ||
|
||
require.Equal(t, "iOS", string(platform)) | ||
require.Nil(t, err) | ||
} | ||
|
||
func TestPlatformsMatching_macOS(t *testing.T) { | ||
buildSettings := serialized.Object{} | ||
buildSettings["SDKROOT"] = "macosx" | ||
|
||
platform, err := getPlatform(buildSettings) | ||
|
||
require.Equal(t, "OS X", string(platform)) | ||
require.Nil(t, err) | ||
} | ||
|
||
func TestPlatformsMatching_fails(t *testing.T) { | ||
buildSettings := serialized.Object{} | ||
platform, err := getPlatform(buildSettings) | ||
|
||
require.Empty(t, platform) | ||
require.NotNil(t, err) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you do not need a separate
OpenArchivableProject
andOpenArchivableWorkspace
.schemeint.Scheme
accepts both a workspace and project path, whatever is provided, it figures out the correct root project (which is connected to the scheme).The issue with the current implementation is at the
OpenArchivableWorkspace
: In the case of a workspace project, a given scheme can be located both under the .xcworkspace or under one of the included .xcproject files, this is handled correctly by theschemeint.Scheme
, butOpenArchivableWorkspace
is not aware of the schemes under the.xcworkspace
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.