Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multithreaded downloading #11

Merged
merged 8 commits into from
Dec 19, 2023
Merged

Multithreaded downloading #11

merged 8 commits into from
Dec 19, 2023

Conversation

imrekel
Copy link
Contributor

@imrekel imrekel commented Dec 19, 2023 •
edited
Loading

Checklist

  • I've read and followed the Contribution Guidelines
  • step.yml and README.md is updated with the changes (if needed)

Version

Requires a MINOR version update

Context

Multithreaded downloads using github.com/melbahja/got. This is much faster for larger files.

Changes

  • The updated version has already been used from the branch by some prospects and seems to work well.
  • Also did a Go version update.

@imrekel imrekel changed the title use got for downloading Multithreaded downloading Dec 19, 2023
@imrekel imrekel requested a review from godrei December 19, 2023 12:23
godrei
godrei previously approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@godrei godrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@imrekel imrekel requested a review from godrei December 19, 2023 13:52
@imrekel imrekel merged commit cf0bc8d into main Dec 19, 2023
1 check passed
@imrekel imrekel deleted the multithreaded-downloading branch December 19, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godrei godrei godrei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imrekel @godrei