Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update artifact_sources input #5

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Conversation

godrei
Copy link
Contributor

@godrei godrei commented Feb 15, 2023

Checklist

  • I've read and followed the Contribution Guidelines
  • step.yml and README.md is updated with the changes (if needed)

Version

Requires a PATCH version update

Context

This PR adds more example to the artifact_sources Step input.

Changes

  • update step.yml
  • update examples.md
  • E2E test fix:

The directory transfer E2E tests were failing, with this error:

actual:
.
└── hello_world.txt
1 directory, 1 file

expected:
.
└── hello_world.txt
0 directories, 1 file

This test case should ensure that the transferred directory layout matches to the original layout. For some reason the originally executed tree command in the artifact producer pipeline, printed a different report at the end of the tree listing, than what we get if execute the same command today (1 directory, 1 file vs 0 directories, 1 file). This is likely due to a version difference between the tree commands. One version included the source directory in the report, while the other didn't.
The fix involved updating the artifact producer pipeline, running a new pipeline build, and based on that, updating the step's E2E tests.

Investigation details

Decisions

@godrei
Copy link
Contributor Author

godrei commented Feb 15, 2023

artifact_sources summary:

Screenshot 2023-02-15 at 14 34 23

artifact_sources description:

Screenshot 2023-02-15 at 14 34 30

@godrei godrei merged commit 80a1467 into main Feb 16, 2023
@godrei godrei deleted the CI-654-artifact_sources-input branch February 16, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants