Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty certificate passphrase #41

Merged
merged 3 commits into from
Mar 21, 2022
Merged

Conversation

ofalvai
Copy link
Contributor

@ofalvai ofalvai commented Mar 18, 2022

Checklist

  • I've read and followed the Contribution Guidelines
  • step.yml and README.md is updated with the changes (if needed)

Version

Requires a PATCH version update

Context

Fixing the same issue as in bitrise-steplib/bitrise-step-manage-ios-code-signing#13

Changes

  • Update go-xcode to pull this change: Improve empty passphrase handling bitrise-io/go-xcode#161
  • passphrase_list input is no longer a required input. This allows using a single certificate without a passphrase because in this case the input should be empty
  • Add E2E test that tests the above by using a single certificate without a passphrase
  • (Not visible in the diff, but) I added this certificate to $BITFALL_APPLE_IOS_CERTIFICATE_URL_LIST and $BITFALL_APPLE_IOS_CERTIFICATE_PASSPHRASE_LIST too, checking the case when one of the supplied certificates is without a passphrase
  • Update step input description

Investigation details

Decisions

@ofalvai ofalvai changed the title Step 1832 no passphrase Allow empty certificate passphrase Mar 18, 2022
@ofalvai ofalvai marked this pull request as ready for review March 21, 2022 08:59
@ofalvai ofalvai merged commit f2eec7e into master Mar 21, 2022
@ofalvai ofalvai deleted the STEP-1832-no-passphrase branch March 21, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants