-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report active Ruby version #95
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
966bfb0
Report active Ruby version
ofalvai dcffef2
Move code around
ofalvai 8a67438
Fix swallowed error
ofalvai c7d8de4
Flip error handling
ofalvai 6199340
Disable test
ofalvai 25cafb1
Fix
ofalvai 1b39c17
Re-enable tests
ofalvai b1dbfe4
Implement step tracker
ofalvai 0a6ea7a
Implement step tracker
ofalvai 8fb8e07
Extra version string validation for rbenv errors
ofalvai 1dd4228
Define workdir in command
ofalvai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| package main | ||
|
|
||
| import ( | ||
| "github.com/bitrise-io/go-utils/v2/analytics" | ||
| "github.com/bitrise-io/go-utils/v2/env" | ||
| "github.com/bitrise-io/go-utils/v2/log" | ||
| ) | ||
|
|
||
| type stepTracker struct { | ||
| tracker analytics.Tracker | ||
| logger log.Logger | ||
| } | ||
|
|
||
| func newStepTracker(envRepo env.Repository, logger log.Logger) stepTracker { | ||
| p := analytics.Properties{ | ||
| "build_slug": envRepo.Get("BITRISE_BUILD_SLUG"), | ||
| "step_execution_id": envRepo.Get("BITRISE_STEP_EXECUTION_ID"), | ||
| "step_id": "fastlane", | ||
| } | ||
| return stepTracker{ | ||
| tracker: analytics.NewDefaultTracker(logger, p), | ||
| logger: logger, | ||
| } | ||
| } | ||
|
|
||
| func (t *stepTracker) logEffectiveRubyVersion(versionString string) { | ||
| properties := analytics.Properties{ | ||
| "effective_ruby_version": versionString, | ||
| } | ||
| t.tracker.Enqueue("step_ruby_version_selected", properties) | ||
| } | ||
|
|
||
| func (t *stepTracker) wait() { | ||
| t.tracker.Wait() | ||
| } |
68 changes: 66 additions & 2 deletions
68
vendor/github.com/bitrise-io/go-steputils/command/rubycommand/rubycommand.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
10 changes: 10 additions & 0 deletions
10
vendor/github.com/bitrise-io/go-steputils/step/steperror.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
6 changes: 3 additions & 3 deletions
6
vendor/github.com/bitrise-io/go-steputils/v2/ruby/environment.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The err check needs to be flipped