Remove PR ID input #196
Merged
Remove PR ID input #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
ofalvai
force-pushed
the
ACI-188-remove-pr-id-input
branch
from
a4795d8 to
2c6727f
Compare
hisaac
approved these changes
Dec 20, 2022
ofalvai
force-pushed
the
ACI-188-remove-pr-id-input
branch
from
90e78da to
331847d
Compare
ofalvai
added a commit
that referenced
this pull request
Dec 20, 2022
* Remove PR ID input * Remove input from config too
ofalvai
added a commit
that referenced
this pull request
Dec 20, 2022
* Reorder inputs and categories * Remove category of merge_pr * Remove PR ID input * Remove input from config too * Better step input descriptions * YAML lint * Reorder inputs and categories (#195) * Reorder inputs and categories * Remove category of merge_pr * Remove PR ID input (#196) * Remove PR ID input * Remove input from config too * Reorder inputs and categories * Fix step.yml after broken merge resolution * Remove category * Revert accidentally readded step input
ofalvai
added a commit
that referenced
this pull request
Jan 3, 2023
* Remove PR ID input * Remove input from config too
ofalvai
added a commit
that referenced
this pull request
Jan 3, 2023
* Reorder inputs and categories * Remove category of merge_pr * Remove PR ID input * Remove input from config too * Better step input descriptions * YAML lint * Reorder inputs and categories (#195) * Reorder inputs and categories * Remove category of merge_pr * Remove PR ID input (#196) * Remove PR ID input * Remove input from config too * Reorder inputs and categories * Fix step.yml after broken merge resolution * Remove category * Revert accidentally readded step input
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
step.ymlandREADME.mdis updated with the changes (if needed)Version
Requires a MAJOR version update
Context
This input is only used in one place, seen in the diff. Even though we check the existence of this input value, we don't read the value ever again, so it doesn't make a change in the step's flow, and the existence of a PR ID is not enough to checkout the PR branch either.
Changes
Remove
pull_request_idstep input instep.ymland code.Investigation details
Decisions
README update will come in a follow-up PR