Initial visionOS support #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofalvai
commented
Feb 22, 2024
e2e/bitrise.yml
Outdated
| - bitrise-run: | ||
| title: Run visionOS test if current stack supports it | ||
| run_if: |- | ||
| {{ and (ne (getenv "BITRISEIO_STACK_ID") "osx-xcode-15.1.x") (ne (getenv "BITRISEIO_STACK_ID") "osx-xcode-15.0.x") (ne (getenv "BITRISEIO_STACK_ID") "osx-xcode-14.3.x-ventura") (ne (getenv "BITRISEIO_STACK_ID") "osx-xcode-14.2.x-ventura") (ne (getenv "BITRISEIO_STACK_ID") "osx-xcode-14.1.x-ventura") (ne (getenv "BITRISEIO_STACK_ID") "osx-xcode-14.0.x-ventura") }} |
There was a problem hiding this comment.
This ugly expression is going to get better over time (we'll remove Xcode 14.0 in 4 weeks, for example).
I also tried to make it easier to read by adding {{ with $stack := getenv "BITRISEIO_STACK_ID" }} ... {{ end }}, but it breaks the expression, it seems like it always returns a truthy value.
There was a problem hiding this comment.
Also, too bad the templating doesn't have a strings.HasPrefix("osx-xcode-14") equivalent :(
There was a problem hiding this comment.
lpusok
previously approved these changes
Feb 22, 2024
e2e/bitrise.yml
Outdated
| - bitrise-run: | ||
| title: Run visionOS test if current stack supports it | ||
| run_if: |- | ||
| {{ and (ne (getenv "BITRISEIO_STACK_ID") "osx-xcode-15.1.x") (ne (getenv "BITRISEIO_STACK_ID") "osx-xcode-15.0.x") (ne (getenv "BITRISEIO_STACK_ID") "osx-xcode-14.3.x-ventura") (ne (getenv "BITRISEIO_STACK_ID") "osx-xcode-14.2.x-ventura") (ne (getenv "BITRISEIO_STACK_ID") "osx-xcode-14.1.x-ventura") (ne (getenv "BITRISEIO_STACK_ID") "osx-xcode-14.0.x-ventura") }} |
There was a problem hiding this comment.
lpusok
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
step.ymlandREADME.mdis updated with the changes (if needed)Version
Requires a MAJOR/MINOR/PATCH version update
Context
Handling visionOS in the SDK parsing is missing at the moment.
Changes
Investigation details
Decisions