Support ShiftLeft and ShiftRight #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemire
reviewed
Aug 23, 2024
|
|
||
| package bitset | ||
|
|
||
| var len8tab = "" + |
There was a problem hiding this comment.
What about adding a quick test? Like...
for k:= 0; k < 64; ++) {
if len64(uint64(1)<<k) != k+1 {
// error!
}
}
|
Looks good to me. Consider adding a sanity test for |
|
Ok. I am merging and releasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #144
Implementation notes
leadingZeroes64()as well aslen64(). I am open to removing it if maintainer(s) request that. I believe though it may be useful in future if golang 1.8 support is not dropped. I have not testedlen64()for older versions very thoroughly so any assistance is appreciated.top() (uint, bool)method might be what was requested in get top bit set? #86 . I did not export it because I'd expect it to accept argument and behave as reversedNextSet(i uint) (uint, bool).