-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Fix cuda toolkit speed issue. #1055
CI: Fix cuda toolkit speed issue. #1055
Conversation
…pendency * use Ninja to compile without MS toolset
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice spot. I did not realize msvc worked without the VS integration of CUDA.
Co-authored-by: Rickard <rickardp@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clean fix !
344e851
into
bitsandbytes-foundation:main
Thanks @wkpark for the clean fix and @rickardp for the review. Looks good also to me! Thanks all for the intervention last week to get everything working again after the premature merge. Shouldn't have done that so hastily, it was based on a miscommunication. I also sent you both an invite for the bitsandbytes Slack channel. In case you want to coordinate PRs, discuss sth important or I don't see something important in time which would make sense to unblock, please feel free to message there or contact me directly through Slack PM. |
Currently, CI uses the Jimver/cuda-toolkit for Windows which has known speed issues when working on Windows.
Jimver/cuda-toolkit#253
specific package
"visual_studio_integration"
is the cause of this speed issue but it is needed to use msbuild.here is the solution.
"visual_studio_integration"
sub-packagegithub-cache
for cuda-tools to fix some broken cases.Cache error log for example.
https://github.com/TimDettmers/bitsandbytes/actions/runs/7804268267/job/21285853144
without this fix: total build time is about ~30 ~40min
with this fix: total build time will be reduced about ~25min