Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt UX improvements #226

Merged
merged 3 commits into from
Jan 23, 2023
Merged

Prompt UX improvements #226

merged 3 commits into from
Jan 23, 2023

Conversation

grctest
Copy link
Contributor

@grctest grctest commented Dec 26, 2022

Make the create/update asset text scrollable
Accept/Reject buttons now properly in view

Fix the 'issue asset' prompt.

Make the create/update asset text scrollable
Accept/Reject buttons now properly in view
Fix the prompt for asset issuance
@grctest grctest changed the title Update transactionrequestpopup.vue Prompt UX improvements Jan 4, 2023
@grctest
Copy link
Contributor Author

grctest commented Jan 9, 2023

Going to do a quick minor refactor in all bitshares prompts, the current operations.push(a + b + c) method will fail entirely if one of the lines is invalid, so instead doing str += "chunk" then operations.push(str) will more reliably render more lines of prompt text. ETA today for changes.

Prevent TOTP prompt if account with wrong chain to request is selected.
Remove dead code
Fix issue with decentralized block list failing
Fix issues with op 12 prompt
Change how all bitshares prompt strings are formed, allowing for greater fault tollerance
@sschiessl-bcp sschiessl-bcp merged commit 51fd818 into bitshares:develop Jan 23, 2023
sschiessl-bcp pushed a commit that referenced this pull request Jan 23, 2023
* Introduce raw deeplink functionality

Add raw beet prompt page
Ensure user is on respective TOTP/RAW deeplink pages when a deeplink is processed. Reduce clickjacking risk.

* Additional checks

Inherit totp improvements from #226
Ensure incoming raw link matches the chain of current selected account
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants