remove get_named_account_balances

[oxarbitrage]

User Story

As a developer I think get_named_account_balances can be removed so the code is easier to maintain.

While making a research on the impact of #1051 i found that get_account_balances already covers what get_named_account_balances do, as the former already accepts an account string.
Update: this is caused by the merge of: #989

I understand there can be some legacy issues by removing get_named_account_balances but there is no point on having it either. I propose to remove it.

Code Reference: https://github.com/bitshares/bitshares-core/blob/master/libraries/app/include/graphene/app/database_api.hpp#L312-L321

Impacts
Describe which portion(s) of BitShares Core may be impacted by your request. Please tick at least one box.

• API (the application programming interface)

CORE TEAM TASK LIST

• Evaluate / Prioritize Feature Request
• Refine User Stories / Requirements
• Design / Develop Solution
  • Issue estimation: 0.5 hours
  • Issue assigned to @cogutvalera
• Perform QA/Testing
• Update Documentation

[abitmore]

I recommend that we keep this API to avoid breaking existing client apps, and document it. We can change the code (the implementation of this API) to call the other API to reduce future maintenance work load.

[oxarbitrage]

good, lets do that.

[cogutvalera]

@abitmore @ryanRfox @oxarbitrage I want to claim this issue, is it possible to assign this issue for me ? Thanks !

[oxarbitrage]

yes

[cogutvalera]

Thanks !

[abitmore]

@oxarbitrage I think it's already implemented as described. Just need to remove code that was commented out. Correct?

[cogutvalera]

@abitmore where did you see that it was already implemented ?

[cogutvalera]

as I've been understood this issue, if I'm not wrong, we don't need to remove comments actually for this issue, we need to remove not required code instead, or isn't so and we just need to remove only comments ?

[oxarbitrage]

need to call the other function straight here https://github.com/bitshares/bitshares-core/blob/master/libraries/app/database_api.cpp#L859-L865

[oxarbitrage]

oops @abit is right https://github.com/bitshares/bitshares-core/blob/develop/libraries/app/database_api.cpp#L882-L890 done in develop.
just need to remove the commented code.

[cogutvalera]

funny issue :-)

[cogutvalera]

I will make PR for this issue very soon :-)

[cogutvalera]

PR #1153 was wrong because was based on master branch instead of develop branch that's why I've closed this PR and opened one new PR #1154

[oxarbitrage]

closed by #1154