-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return total number of available assets #688
Comments
@startailcoon although returning the total number of assets is not hard, I think it's better that the UI don't try to load all assets if only for the "search" feature. That said, sooner or later we'll be unable or unpractical to fetch all assets, so we need to find a better implementation for the search feature, and likely need to change UX. I will leave this issue open so far, looking forward to more discussion. But don't just do it. |
The UI currently does this since before, which is why it takes so long for users to search for assets. A better way should be implemented to the UI. |
Anyway, adding a |
|
I want to claim this issue @oxarbitrage @abitmore @ryanRfox is it possible ? Thanks ! |
PR is ready |
fixed issue #688, add get_asset_count API
added new api call for this |
The UI has an issue, bitshares/bitshares-ui#1070, related to loading assets over a slow connection.
I have not been able to find a call that can accommodate the need for this directly. If I've overlooked something, please let me know.
Issue
When a user is navigating to the assets section of the UI, the app uses the API Call
graphene::app::database_api::list_assets
by loading 100 assets at the time from A -> Z until it reaches the end of all available assets.When a user has a slow connection, this will take longer time and during this time the user can't find an yet to load asset.
For the time, we can rely on a cached maximum between sessions as a workaround, but the initial loading will never know how many assets there are until they are all loaded.
Requested Feature
An API call that can return the total number of assets available so we can know when this loading is completed.
CORE TEAM TASK LIST
The text was updated successfully, but these errors were encountered: