Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to use database API in cli_wallet for example get_full_accounts method? #811

Closed
wwg2018new opened this issue Apr 4, 2018 · 3 comments

Comments

@wwg2018new
Copy link

unlocked >>> get_full_accounts
get_full_accounts
10 assert_exception: Assert Exception
itr != _by_name.end(): no method with name 'get_full_accounts'

@oxarbitrage
Copy link
Member

currently not possible but it is something we should do in the future. most probably cli wallet issues will be included after next hard fork release(develop branch may have cli wallet changes at any time).

right now what we do to support a new call from api in wallet is to add a dedicated call in wallet.cpp that calls the remote database api. we pretty much need a call in wallet for each api call.

what do you guys think on having some way to access any call inside the database api by creating a function specifically for it, something like this in the wallet:
pretty_json call_database_api(string call name, array arguments);

it can save us some time as we will not need to create version of everything, we can leave versioned functions to specific calls that need output formatting and processing but have this to direct access to api calls.

@abitmore
Copy link
Member

@oxarbitrage I think it's a good idea to have a generic way to access database APIs directly from cli_wallet. However there may be compatibility issues, e.g. same API name but with different parameter list/types (like proposed in #861). It's low priority IMHO.

oxarbitrage added a commit that referenced this issue May 12, 2018
#811, add get_full_accounts api in cli_wallet
@oxarbitrage
Copy link
Member

closed by #861

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants