Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand get_top_markets API to return more data fields #842

Closed
abitmore opened this issue Apr 13, 2018 · 2 comments
Closed

Expand get_top_markets API to return more data fields #842

abitmore opened this issue Apr 13, 2018 · 2 comments
Assignees
Labels
2c Ready for Development Status indicating the Requirements are sufficent to begin designing a solution api feature

Comments

@abitmore
Copy link
Member

Expand get_top_markets API to return more data fields, specifically, the fields returned by get_ticker API. Or create a new API to return vector<market_ticker>.

Other than that, we still need to think how to improve the APIs to avoid being spammed / manipulated, as discussed here: #560 (comment).

Please discuss.

@abitmore abitmore added this to the Future Non-Consensus-Changing Release milestone Apr 13, 2018
@ryanRfox ryanRfox added the 2c Ready for Development Status indicating the Requirements are sufficent to begin designing a solution label Jun 14, 2018
@abitmore
Copy link
Member Author

abitmore commented Feb 1, 2019

There were some (maybe useful) comments in #924.

#924 (comment) by @jhtitor:

I have 2 cents from bitshares-qt standpoint.

First of all, the get_top_markets API itself is a great idea, and I'm really glad we finally have such a feature. Going to use it extensively.

Secondly, I think it would be great, if the API could be expanded to allow setting base asset. Say, a user is interested in trading OPEN.BTC -- I want to show top OPEN.BTC markets. The current behavior (listing everything) is also extremely useful, so I'm not proposing to replace it.

Sorry if this is the wrong ticket, which only deals with the return format.

#924 (comment) by me:

I too want to leave something here for reference, but don't want to write a feature request yet:

oxarbitrage added a commit that referenced this issue Feb 5, 2019
@oxarbitrage
Copy link
Member

closed by #1549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2c Ready for Development Status indicating the Requirements are sufficent to begin designing a solution api feature
Projects
None yet
Development

No branches or pull requests

3 participants