remove needless find() in p2p #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxarbitrage
approved these changes
Jun 25, 2018
|
@oxarbitrage code related to p2p should not affect replay at all. We need to test re-syncing. |
abitmore
approved these changes
Jun 26, 2018
|
BTW I guess the |
yes, actually i did re-syncing, used the wrong word. didn't made full resync but around 1/4 when testing this. |
nanomobile
pushed a commit
to nanomobile/bitshares-core
that referenced
this pull request
Jul 1, 2018
remove needless find() in p2p
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1090
find() was being called 3 times on 2 different collections, when 1 call on each would suffice.