add quit command to cli_wallet #1050

[nanomobile]

PR for #1050.

[nanomobile]

just FC_THROW isn't enough as I've tested it just print message and that's all

[nanomobile]

@ryanRfox @abitmore @oxarbitrage @jmjatlanta @clockworkgr I've added test case as requested and try/catch block, still cannot understand what to use instead of EXIT, can anybody advise anything what is the best to use instead of EXIT ?

c61a994

Thanks everybody !

[oxarbitrage]

please research for an alternative and present for discussion all the options you can find, we don't know either.

[oxarbitrage]

the test is not enough in my opinion. it needs to create some accounts, move some balances, then quit. then open again, use the file to restore and check if the movements done are there.

[nanomobile]

ok sure ! Thanks ! 👍

[nanomobile]

I see that even in libraries exit is still used in many different places, for example:

1. https://github.com/bitshares/bitshares-core/blob/master/libraries/app/application.cpp#L425
2. https://github.com/bitshares/bitshares-core/blob/master/libraries/app/application.cpp#L988
3. https://github.com/bitshares/bitshares-core/blob/master/libraries/app/application.cpp#L1019

and in the whole project there are also other places with exit method. So what can you say about that guys @oxarbitrage @abitmore @ryanRfox @jmjatlanta @clockworkgr ? Why there is it OK but not here ? Or there isn't OK too ?

[abitmore]

@nanomobile thanks for the report. We need to fix those. Exiting from a library makes it very hard if not impossible to test with boost testing framework. For the 2 exiting on error, should change to throw an exception. For the other one, probably should return a special value then check at where calling it. Need to create new issues for these though.

[nanomobile]

there are not only 3 places with exit method, we need to fix all IMHO

[abitmore]

Created new issue: #1110, please feel free to add more findings there. Thanks.

[cogutvalera]

just rebased current changes in this PR to be synced with core/develop, soon will make more commits in order to make everything correctly and close this issue

[cogutvalera]

instead of using exit(0) it's much better to use _Exit(0) as described here http://www.cplusplus.com/reference/cstdlib/_Exit/ :

Terminate calling process
Terminates the process normally by returning control to the host environment, but without performing any of the regular cleanup tasks for terminating processes (as function exit does).

No object destructors, nor functions registered by atexit or at_quick_exit are called.

Whether C streams are closed and/or flushed, and files open with tmpfile are removed depends on the particular system or library implementation.

If status is zero or EXIT_SUCCESS, a successful termination status is returned to the host environment.
If status is EXIT_FAILURE, an unsuccessful termination status is returned to the host environment.
Otherwise, the status returned depends on the system and library implementation.
Data races
Concurrently calling this function multiple times has no effect.

Exceptions (C++)
No-throw guarantee: this function never throws exceptions.

[cogutvalera]

guys check and test this pull request please if this issue can be closed or not yet ...
Thanks !

[cogutvalera]

ok sure ! Thanks ! Will fix now !

[pmconrad]

Now it's wrong. void quit() doesn't return anything.
If you want to keep the comment you must fix the perl script. :-)

[cogutvalera]

ok understood :-) will remove it :-)

New commits added

[abitmore]

@cogutvalera please bump FC to latest version to include the time_point_sec stringify test fix.

[cogutvalera]

Bump FC is done ! Thank you guys !

[jmjatlanta]

How to validate the wallet file:

[abitmore]

Manual test:

new >>> quit
quit
2551611ms th_a       wallet.cpp:780                quit                 ] Quitting Cli Wallet ...
9 canceled_exception: Canceled

2551611ms th_a       wallet.cpp:799                save_wallet_file     ] saving wallet to file wallet.json
pure virtual method called
terminate called without an active exception
Aborted (core dumped)

• Best if 9 canceled_exception: Canceled is not there, but this is a minor issue.
• wallet file does get saved
• the crash after saved wallet file is another common issue, if press Ctrl+D:

new >>>

2614126ms th_a       wallet.cpp:799                save_wallet_file     ] saving wallet to file wallet.json
pure virtual method called
terminate called without an active exception
Aborted (core dumped)