Fixes to make Docker containers shutdown properly #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tydus thanks for the pull request. Please rebase and change the base of this PR to |
Making a dockerized daemon receive SIGTERM could be very tricky: firstly, CMD should not use the "shell form", otherwise a "sh -c" process will possess the PID 1 therefore no one can receive the SIGTERM sent from "docker stop"; second, the bitsharesentry.sh should call $BITSHARESD with exec, i.e. let the daemon take the same PID (i.e. 1). Or in another way, a "trap SIGTERM" trick may be employed to make sure the SIGTERM is forwarded to the actual daemon process.
|
@abitmore Thanks abit. It looks OK now. |
|
Thanks. |
xeroc
approved these changes
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making a dockerized daemon receive SIGTERM could be very tricky:
firstly, CMD should not use the "shell form", otherwise a "sh -c" process will possess the PID 1 therefore no one can receive the SIGTERM sent from "docker stop";
second, the bitsharesentry.sh should call $BITSHARESD with exec, i.e. let the daemon take the same PID (i.e. 1). Or in another way, a "trap SIGTERM" trick may be employed to make sure the SIGTERM is forwarded to the actual daemon process.
The second patch is optional. I personally encountered segfaults while sending SIGTERM to witness, however SIGINT works well ever.
See also: https://hynek.me/articles/docker-signals/