Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1121

Merged
merged 1 commit into from
Jul 21, 2018
Merged

Update README.md #1121

merged 1 commit into from
Jul 21, 2018

Conversation

lososeg
Copy link
Contributor

@lososeg lososeg commented Jul 5, 2018

I did not have enough make, automake and libtool packages to build on ubuntu 16.04.

@abitmore
Copy link
Member

abitmore commented Jul 5, 2018

Thanks.

We can merge it to master branch now because master is the default branch, most people will read docs in master branch.

We need to cherry-pick it to develop branch as well.

@lososeg
Copy link
Contributor Author

lososeg commented Jul 5, 2018

I had a error “failed to run aclocal: No such file or directory”. And it was decided only after installing automake (make was already installed)

@abitmore
Copy link
Member

abitmore commented Jul 6, 2018

@lososeg I guess you're using an Ubuntu "minimal" installation or similar. Ubuntu 16.04 server installation by default will have the 3 packages you mentioned.

@lososeg
Copy link
Contributor Author

lososeg commented Jul 8, 2018

May be, I test it on hetzner's VDS.

pmconrad
pmconrad previously approved these changes Jul 17, 2018
@pmconrad pmconrad dismissed their stale review July 17, 2018 15:27

fumbled

Copy link
Contributor

@pmconrad pmconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on release branch so we can merge this into develop easily.

@lososeg lososeg changed the base branch from master to release July 17, 2018 19:12
@abitmore abitmore changed the base branch from release to tmp1 July 21, 2018 21:07
@abitmore abitmore dismissed pmconrad’s stale review July 21, 2018 21:08

I will take care of it.

@abitmore abitmore merged this pull request into bitshares:tmp1 Jul 21, 2018
This was referenced Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants