Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed push_proposal exception log level to warn #1146

Merged
merged 1 commit into from
Jul 21, 2018
Merged

Changed push_proposal exception log level to warn #1146

merged 1 commit into from
Jul 21, 2018

Conversation

abitmore
Copy link
Member

IMHO the original log level (error) is too aggressive for push_proposal(...) call.

@oxarbitrage oxarbitrage self-requested a review July 16, 2018 21:40
oxarbitrage
oxarbitrage approved these changes Jul 16, 2018
View reviewed changes
Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree.

@abitmore abitmore merged commit de07497 into develop Jul 21, 2018
@abitmore abitmore deleted the abitmore-patch-3 branch July 21, 2018 17:12
@abitmore abitmore mentioned this pull request Aug 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
201808 - Non-Consensus-Changing Release
Development

Successfully merging this pull request may close these issues.
2 participants
@abitmore @oxarbitrage