Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segregate obnoxiously slow test #1160

Closed
wants to merge 1 commit into from
Closed

Segregate obnoxiously slow test #1160

wants to merge 1 commit into from

Conversation

abitmore
Copy link
Member

Cherry-picked from #1126.

@nathanhourt wrote:

The main test driver should run fairly quickly; extremely slow tests should be moved to a
separate driver so developer time isn't wasted waiting for many runs of a slow test.

Really more tests should be moved over, but I'm too lazy right now.

I wrote:

There were efforts to include all consensus related tests into chain_test. Moving tests outside of chain_test will likely make them be ignored and may cause unexpected consequences.

More input wanted. Thanks.

The main test driver should run fairly quickly; extremely slow tests should be moved to a
separate driver so developer time isn't wasted waiting for many runs of a slow test.

Really more tests should be moved over, but I'm too lazy right now.
@abitmore abitmore added the 2a Discussion Needed Prompt for team to discuss at next stand up. label Jul 21, 2018
@jmjatlanta
Copy link
Contributor

jmjatlanta commented Sep 3, 2018

My opinion: All tests should run by default. Perhaps we can subdivide tests yet again? ./chain-test --run_test=fast_tests/* Or maybe categorize by importance. So if there is a slow test, but it checks something very idiosyncratic, put it in "simple_tests" suite instead of "critical_tests". But if it is slow and very important... well, you get the picture.

@abitmore
Copy link
Member Author

abitmore commented Sep 3, 2018

Thanks to @pmconrad, Travis build is now much faster, I think we can add more tests there.

@pmconrad
Copy link
Contributor

Agree with @jmjatlanta - all tests should be run by default. call_order_tests takes 10 seconds on my desktop, that's nothing.
IMO can close this PR without merging.

@pmconrad
Copy link
Contributor

No further comments - closing.

@pmconrad pmconrad closed this Oct 10, 2018
@pmconrad pmconrad deleted the slow-tests branch October 10, 2018 15:47
@pmconrad pmconrad removed this from the 201812 - Feature Release milestone Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2a Discussion Needed Prompt for team to discuss at next stand up.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants