Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove protocol.hpp #1200

Merged
merged 1 commit into from
Jul 29, 2018
Merged

Remove protocol.hpp #1200

merged 1 commit into from
Jul 29, 2018

Conversation

oxarbitrage
Copy link
Member

for issue #1197

@abitmore
Copy link
Member

  • I forgot to add "good first issue" tag to the issue, didn't want to squeeze your time
  • unexpected binary should not ever be in commit history. Please "squash" your commits and force push.

@oxarbitrage
Copy link
Member Author

no worries, wanted to do it. sorry about the binary, should be fixed now. thanks.

abitmore
abitmore approved these changes Jul 29, 2018
View reviewed changes
Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@abitmore abitmore merged commit aa28044 into bitshares:develop Jul 29, 2018
This was referenced Jul 29, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abitmore abitmore abitmore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
201808 - Non-Consensus-Changing Release
Development

Successfully merging this pull request may close these issues.
2 participants
@oxarbitrage @abitmore