Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change BTS to GRAPHENE_SYMBOL for testnet cli_test #1227

Merged
merged 1 commit into from
Aug 3, 2018
Merged

Change BTS to GRAPHENE_SYMBOL for testnet cli_test #1227

merged 1 commit into from
Aug 3, 2018

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Aug 3, 2018

Travis complains when running cli_test for testnet branch (link):

3364738ms th_a main.cpp:512 test_method ] e.to_detail_string(): 10 assert_exception: Assert Exception
a:
{}
th_a wallet.cpp:3213 get_asset
{"from_account_id_or_name":"nathan","asset_symbol":"BTS","to_amounts":[["nathan","100000000"]]}
th_a wallet.cpp:4488 transfer_to_blind

This PR changed hard coded BTS to GRAPHENE_SYMBOL in order to fix this.

oxarbitrage
oxarbitrage approved these changes Aug 3, 2018
View reviewed changes
Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense. thanks.

@abitmore abitmore merged commit e259711 into release Aug 3, 2018
@abitmore abitmore deleted the abitmore-patch-1 branch August 3, 2018 12:19
@abitmore abitmore mentioned this pull request Aug 4, 2018
Closed
@abitmore abitmore mentioned this pull request Sep 13, 2020
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
201808 - Non-Consensus-Changing Release
Development

Successfully merging this pull request may close these issues.
2 participants
@abitmore @oxarbitrage