refactor get_assets to accept id or name #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abitmore
reviewed
Aug 22, 2018
| optional<asset_object> find_asset(asset_id_type id)const | ||
| { | ||
| auto rec = _remote_db->get_assets({id}).front(); | ||
| auto rec = _remote_db->get_assets({asset_id_to_string(id)}).front(); |
There was a problem hiding this comment.
This looks ugly as well.
Perhaps better to add another get_assets_by_id() API?
There was a problem hiding this comment.
Why didn't change find_asset(asset_id_type id) to find(string)? Is it an function that only used internally?
There was a problem hiding this comment.
Anyway, I think cli_wallet is less important, it's fine to have some ugly code and slightly reduced performance.
|
Good job. Thanks. |
abitmore
reviewed
Aug 23, 2018
abitmore
reviewed
Aug 23, 2018
|
I exposed I think it can be of use and wont hurt to have them available for API users. |
abitmore
reviewed
Feb 3, 2019
abitmore
reviewed
Feb 3, 2019
abitmore
approved these changes
Feb 4, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull request to start the work in #1051
the first commit refactor
get_assetsapi call to accept name or id on the arguments.i need you guys to take a look so i can continue in this way for all the calls if i can get a green light here.
this follow the same idea of what we did for all account api calls at: #989