Custom authorities #1362
Closed
Custom authorities #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed from reference, to avoid unexpected nullptr dereference
still need to add checks in do_evaluate()
Need to update FC to master after changes got merged into master
abitmore
commented
Oct 7, 2018
| template<typename OpType> | ||
| result_type operator()( const OpType& ) // Note: the parameter is a reference of *nullptr, we should not use it | ||
| { | ||
| FC_ASSERT( _restriction.member < fc::reflector<OpType>::total_member_count, |
There was a problem hiding this comment.
We call visit_local_member below, so it makes more sense to check local_member_count rather than total_member_count here.
abitmore
commented
Oct 10, 2018
| void validate_restriction_details( const restriction& r, unsigned_int op_type ) | ||
| { | ||
| restriction_validation_visitor vtor( r ); | ||
| switch( op_type.value ) |
There was a problem hiding this comment.
Need to refactor due to changes on static_variant: bitshares/bitshares-fc#79
abitmore
modified the milestones:
201905 - Consensus-Upgrade Release,
201911 - Consensus-Upgrade Release
|
Work in progress here: blockops-de#1 |
|
Closing in favor of #1860. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress for BSIP40 / #1285.
Not ready for merge.
Task list: