Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build errors and a warning #1421

Closed
wants to merge 3 commits into from
Closed

Fix build errors and a warning #1421

wants to merge 3 commits into from

Conversation

nathanielhourt
Copy link
Contributor

@nathanielhourt nathanielhourt commented Nov 7, 2018 •
edited
Loading

  • Fix warning that using std::move on a temporary value prevents copy elision
  • Add missing FC_REFLECT_TYPENAME on account operation extensions
  • Replace deprecated call to fc::rand_pseudo_bytes with
    fc::rand_bytes.
  • Include smart_ref_impl.hpp in fork_database.cpp which is required for build on some configurations

@nathanielhourt
Fix warning
40592b7 
Potential optimization: don't move a temporary as this prevents
copy elision
@nathanielhourt
Fix build errors
7631b9b 
 - Add missing FC_REFLECT_TYPENAME on account operation extentions
 - Replace deprecated call to fc::rand_pseudo_bytes with
fc::rand_bytes.
@nathanielhourt
Include smart_ref_impl from fork_database.cpp
67ccc53 
Required for build on some configurations
@nathanielhourt
Copy link
Contributor Author

Hmm, that travis failure makes no sense to me. I'm not sure how 67ccc53 could cause that failure, could the travis tests be unstable?

@oxarbitrage
Copy link
Member

Hmm, that travis failure makes no sense to me. I'm not sure how 67ccc53 could cause that failure, could the travis tests be unstable?

Just restarted travis build for this as yes, sometimes the cli_tests fails and we dont know the exact reason. Lets see how it goes now.

oxarbitrage
oxarbitrage approved these changes Nov 7, 2018
View reviewed changes
Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, thanks.

@oxarbitrage oxarbitrage changed the base branch from master to develop November 9, 2018 13:29
@oxarbitrage oxarbitrage changed the base branch from develop to master November 9, 2018 13:30
@oxarbitrage
Copy link
Member

sorry, i didn't saw here the pull is against master. You need to send to develop branch. Can you do it ? If not i can do it for you.

@oxarbitrage oxarbitrage mentioned this pull request Nov 9, 2018
Merged
@oxarbitrage
Copy link
Member

moved to #1426

@oxarbitrage oxarbitrage closed this Nov 9, 2018
@nathanielhourt nathanielhourt deleted the patch-0 branch November 9, 2018 22:28
oxarbitrage added a commit that referenced this pull request Nov 10, 2018
@oxarbitrage
Merge pull request #1426 from oxarbitrage/fix-build-errors
32d8d08 
Fix build errors - replaces #1421
@MichelSantos MichelSantos mentioned this pull request Feb 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanielhourt @oxarbitrage