get_key_references should not subscribe to related accounts (Issue 1472)

[jmjatlanta]

Fixes #1472

[pmconrad]

IMO limiting this to an arbitrary value is the wrong approach. Either you want the subscriptions, or you don't. (I guess you don't, so perhaps better remove them completely.)

[abitmore]

I agree with @pmconrad. Likely clients will call get_full_accounts or similar after calling this.

[jmjatlanta]

get_key_references no longer subscribes to associated accounts, although it still subscribes to the passed-in keys.

#1472 mentions limiting the size of final_results. Should that be an arbitrary number? Should it be configurable? Perhaps it should be done under another issue (more discussion needed)?

[pmconrad]

IMO you could limit the size of the incoming vector to a fixed value. Making this configurable is part of #782 / #1478.
Adding limits to the output would also require start and limit parameters, which breaks compatibility. IMO the performance impact is limited anyway.

[jmjatlanta]

IMO you could limit the size of the incoming vector to a fixed value. Making this configurable is part of #782 / #1478.

I interpret the above as "set the max limit of the incoming vector to 100 items, and ask manikey123 to make the 100 configurable. Do nothing to limit the size of the returned vector." Is that the correct interpretation?

[pmconrad]

That's my suggestion, yes.

[pmconrad]

Thanks. I think that's sufficient protection. There are easier ways to overload API nodes than this one.