Prevent current > max supply and call_order_update proposal #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmjatlanta
commented
Feb 7, 2019
| d.adjust_balance( o.funding_account, o.delta_debt ); | ||
|
|
||
| // Deduct the debt paid from the total supply of the debt asset. | ||
| d.modify(*_dynamic_data_obj, [&](asset_dynamic_data_object& dynamic_asset) { | ||
| d.modify( *_dynamic_data_obj, [ this, &o ]( asset_dynamic_data_object& dynamic_asset ) { |
There was a problem hiding this comment.
The ASSERTs were originally within the d.modify. Moved to before d.adjust_balance, as it seems to make more sense. Please correct me if the logic is flawed.
Also, some branches do not contain the verification that the current supply is non-negative. Perhaps that check is done elsewhere?
jmjatlanta
commented
Feb 7, 2019
| { | ||
| ilog( "20181206A: proposal contains call_order_update at ${bt}: ${op}", ("bt",block_time)("op",v) ); | ||
| FC_ASSERT( block_time < fc::time_point::now() - fc::seconds(30), "Soft fork - preventing proposal with call_order_update!"); | ||
| } |
There was a problem hiding this comment.
I believe the interpretation is: For CNY, prediction markets can have proposals with call_order_update. Otherwise, we ASSERT. I believe the softfork protection should be changed to hardfork protection (backdated to late Dec.?)
jmjatlanta
commented
Feb 7, 2019
| for( const op_wrapper& op : v.proposed_ops ) | ||
| { | ||
| op.op.visit( *this); | ||
| if ( nested_soft_fork && op.op.which() == operation::tag<proposal_update_operation>().value ) |
There was a problem hiding this comment.
Will reword this section based on answers to questions above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready for review. Currently examining the approach.
This is a fairly direct port of the patch. PR comments indicate the areas I have questions.