Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing tests in testnet #1594

Merged
merged 4 commits into from
Feb 18, 2019

Conversation

oxarbitrage
Copy link
Member

This fix the testnet testcases pointed by @jmjatlanta at #1574

The market_tests were easy as we have constants.

The bitasset_tests/hf_935_test is a tough one for me, had problems before so some help will be appreciated to look for an alternative, the buch of blocks generated in this fix is ugly.

Thanks.

tests/tests/market_tests.cpp Outdated Show resolved Hide resolved
tests/tests/bitasset_tests.cpp Outdated Show resolved Hide resolved
Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The database_fixture change works, although is a bit ugly, it's better than generating a lot of blocks. IMHO we can merge after wrapped the long line.

tests/tests/market_tests.cpp Outdated Show resolved Hide resolved
@oxarbitrage
Copy link
Member Author

The database_fixture change works, although is a bit ugly, it's better than generating a lot of blocks.

I agree. There are other similars(

if( !options.count("track-account") && current_test_name == "track_account2") {
) in the database fixture that are also ugly. This issues can be grouped, they should be initialized for each case by a constructor or something. Of course, for a new issue, not here.

@oxarbitrage oxarbitrage merged commit 78aca20 into bitshares:hardfork Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants