Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slightly improve limit order creation performance #1621

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Slightly improve limit order creation performance #1621

merged 1 commit into from
Feb 27, 2019

Conversation

abitmore
Copy link
Member

Follow up #1608

pmconrad
pmconrad approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@pmconrad pmconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's worth the trouble. Getting rid of a local variable is probably something the optimizer will do anyway when applicable.

@abitmore
Copy link
Member Author

This PR saves a DB query (at least looks like it). I'm not sure about the local variable either.

@abitmore abitmore merged commit fe510a2 into develop Feb 27, 2019
@abitmore abitmore deleted the abitmore-patch-1 branch February 27, 2019 12:47
@MichelSantos MichelSantos mentioned this pull request May 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmconrad pmconrad pmconrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0 - Feature Release
Development

Successfully merging this pull request may close these issues.
2 participants
@abitmore @pmconrad