Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testnet release to add HTLC Blacklist functionality #1664

Merged
merged 17 commits into from
Mar 22, 2019
Merged

Testnet release to add HTLC Blacklist functionality #1664

merged 17 commits into from
Mar 22, 2019

Conversation

jmjatlanta
Copy link
Contributor

This PR will release the blacklist functionality to HTLCs in TESTNET. At contract create time, white/blacklists will be checked.

@abitmore
Copy link
Member

abitmore commented Mar 19, 2019 •
edited
Loading

Do we need another hardfork? Has anyone broken the unsaid rule in testnet?

@jmjatlanta
Copy link
Contributor Author

No one has done it to my knowledge.

@pmconrad
Copy link
Contributor

Wait with merge until #1656 is in?

@jmjatlanta
Copy link
Contributor Author

Wait with merge until #1656 is in?

If we can get 1656 in, that would be great. But I feel we want this boat to sail and we're being held up by a knot in a line.

@abitmore
Copy link
Member

I prefer containing #1656 in next release. Otherwise there would be an API change after the release which would bring more confusion.

pmconrad
pmconrad suggested changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@pmconrad pmconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR test fails in travis with tx size limit exceeded. Not sure if the failure is already in testnet_release or due to this PR. Please check and fix in any case.

@jmjatlanta
Copy link
Contributor Author

jmjatlanta commented Mar 20, 2019 •
edited
Loading

At first glance, it looks like the new transaction size code is preventing a STEALTH test in cli_test. I would guess it is a problem already in the TESTNET branch, but I am investigating.

Update: cli_test in the current testnet branch also fails. So it is a problem, but not caused by these recent updates. I will attempt to fix in a separate PR.

@jmjatlanta
Copy link
Contributor Author

jmjatlanta commented Mar 21, 2019 •
edited
Loading

Earlier test failure was unrelated to this PR. New PR created to fix test failure: #1665

@jmjatlanta
Merge pull request #1665 from bitshares/jmj_confidential_tx_test
1a1ba7e 
Increase max_transaction_size for confidential_tx test
@jmjatlanta
Merge pull request #1656 from bitshares/jmj_1645
11432f3 
Change format of get_htlc output
@jmjatlanta jmjatlanta requested a review from pmconrad March 22, 2019 11:22
@jmjatlanta jmjatlanta merged commit 93f893f into testnet_release Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmconrad pmconrad pmconrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0 - Protocol Upgrade Release
Development

Successfully merging this pull request may close these issues.
3 participants
@jmjatlanta @abitmore @pmconrad