Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some warnings #1677

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Fix some warnings #1677

merged 1 commit into from
Mar 25, 2019

Conversation

nathanielhourt
Copy link
Contributor

A sister PReq to bitshares/bitshares-fc#116, fix some warnings in the BitShares repo as well:

  • Add a virtual destructor to peer_connection_delegate to squelch warnings from inheritors that the class has virtual methods, but no virtual destructor
  • A few test sites reference ->id without using it as a shorthand to crash if a newly created object is null, but this causes unused reference warnings, so make the checks explicit instead.

@nathanielhourt nathanielhourt merged commit b96cc0c into bitshares:develop Mar 25, 2019
@nathanielhourt nathanielhourt deleted the warnings branch March 25, 2019 14:05
@MichelSantos MichelSantos mentioned this pull request May 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abitmore abitmore abitmore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0 - Feature Release
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanielhourt @abitmore