Fix Windows build errors #1704
Merged
Fix Windows build errors #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was fc already bumped to include these changes in develop branch? If not please do so. |
|
The fc version doesn't exist, please double-check and force-push |
jmjatlanta
force-pushed
the
jmj_1593
branch
2 times, most recently
from
aa9dc1c to
283515d
Compare
|
Sorry, but you have to rebase on latest develop to avoid the conflict. |
Rebased, conflict resolved. Thanks. |
pmconrad
approved these changes
Apr 29, 2019
|
Looks good, but can't test windows build. Travis + docker are ok, so who cares? ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1593
With these changes (and the ones already merged to bitshares-fc:master), bitshares-core now builds on Windows 10.