add htlc api calls #1729
Closed
add htlc api calls #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pmconrad
reviewed
Apr 29, 2019
| std::for_each(htlc_range.first, htlc_range.second, | ||
| [&acnt] (const htlc_object& htlc) { | ||
| acnt.htlcs.emplace_back(htlc); | ||
| }); |
There was a problem hiding this comment.
Also list htlcs for which the account is the recipient?
pmconrad
reviewed
Apr 29, 2019
|
|
||
| vector<htlc_object> database_api_impl::get_htlc_by_from(const std::string account_id_or_name, htlc_id_type start, uint32_t limit) const | ||
| { | ||
| FC_ASSERT( limit <= 101 ); |
There was a problem hiding this comment.
When adding new API calls with limits, please make the limit configurable as in #1513
pmconrad
reviewed
Apr 29, 2019
| vector<htlc_object> database_api_impl::get_htlc_by_to(const std::string account_id_or_name, htlc_id_type start, uint32_t limit) const | ||
| { | ||
|
|
||
| FC_ASSERT( limit <= 101 ); |
There was a problem hiding this comment.
When adding new API calls with limits, please make the limit configurable as in #1513
pmconrad
reviewed
Apr 29, 2019
|
|
||
| /** | ||
| * @brief Get HTLC object | ||
| * @param id HTLC contarct id |
pmconrad
reviewed
Apr 29, 2019
| /** | ||
| * @brief Get non expired HTLC objects using the sender account | ||
| * @param account Account ID or name to get objects from | ||
| * @param start Withdraw permission objects(1.16.X) before this ID will be skipped in results. Pagination purposes. |
pmconrad
reviewed
Apr 29, 2019
| /** | ||
| * @brief Get non expired HTLC objects using the receiver account | ||
| * @param account Account ID or name to get objects from | ||
| * @param start Withdraw permission objects(1.16.X) before this ID will be skipped in results. Pagination purposes. |
Merged
|
Closing in favour of #1742 |
|
does full accounts now contain htlc objects for |
|
@syalon yes. |
|
@pmconrad this PR would be marked as "merged" automatically if you didn't close it (move the mouse to the "reopen and comment" button then we can see a tooltip). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: changes in this pull requests have been merged in #1742.
partially resolves #1713 by adding 3 api calls:
The
get_htlc_by_fromandget_htlc_by_tofollows some of the last group of api calls added for the recurring payments(get_withdraw_permissions_by_giver and get_withdraw_permissions_by_recipient)fromones following again the withdraw calls. Thetoones can be added easily if needed.Unsure if we really need a call to list all htlc objects in the blockchain, maybe a use case will help here.
No cli wallet commands are added in this pull request, i tried to make it small enough to be able to get in the next feature release.