Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extending pull #1528 (cli wallet rpc logging) #1807

Closed
wants to merge 7 commits into from
Closed

Extending pull #1528 (cli wallet rpc logging) #1807

wants to merge 7 commits into from

Conversation

oxarbitrage
Copy link
Member

Added command line options as suggested by #1528 (comment) among some other small code style fixes.

This can replace #1528

@abitmore
Copy link
Member

abitmore commented Jun 20, 2019 •
edited
Loading

This can replace #1528

Why not create a pull request against jmj1149 branch directly? Or directly push to the branch if @jmjatlanta agrees? So it's easier for reviewers to know what are the new changes.

@abitmore abitmore added this to the 3.2.0 - Feature Release milestone Jun 20, 2019
@oxarbitrage oxarbitrage changed the base branch from develop to jmj_1149 June 20, 2019 16:40
@oxarbitrage oxarbitrage changed the base branch from jmj_1149 to develop June 20, 2019 16:40
@oxarbitrage
Copy link
Member Author

Will create new pull to jmj1149

@oxarbitrage oxarbitrage mentioned this pull request Jun 20, 2019
Merged
@abitmore abitmore removed this from the 3.2.0 - Feature Release milestone Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oxarbitrage @abitmore @jmjatlanta