BSIP 40: Tests of special custom authorities #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmconrad
reviewed
Dec 10, 2019
| vector<restriction>{restriction(asset_id_index, FUNC(eq), | ||
| asset_id_type( | ||
| bcoin2.id.instance()))})}; | ||
| restriction sell_bcoin_rx = restriction(dummy_index, FUNC(logical_or), |
There was a problem hiding this comment.
Maybe replace one of the logical_or with a list in function?
There was a problem hiding this comment.
This was a very good suggestion Peter. By using the in function, the full set of pairs could be combined and only consume 9 restrictions with almost limitless assets on either side of the permitted exchange sets.
Another benefit is that 9 restrictions is less than the likely 10 restriction limit per custom authority which means that the restricted trading can be described by one custom authority rather than 2 custom authorities.
17 tasks
|
Created #2082 for documenting the weaknesses. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests to confirm new custom authority templates for restricted trading, for voting, and for changing a witness signing key