Get around CURLOPT_POSTFIELDS bug, fix node crash #2491
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2490.
Without the curl/curl#3549 patch, there will be a
strlen
call on the uninitializedCURLOPT_POSTFIELDS
field which causes crash.With this pull request,
CURLOPT_POSTFIELDS
is always initialized.Update: this patch is not ideal. See the updated issue description for more info.