New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code smells #2661

Merged

abitmore merged 13 commits into develop from fix-code-smells

Oct 27, 2022

Member

abitmore commented Oct 23, 2022 •

edited

Loading

In addition to code smell fixes, this PR contains improvements:

Simplify help info in cli_wallet
- Removed const, &, std:: and less<> from help info for simplicity (only if Doxygen is found at build time)
Extend transaction_handle_type to 32 bits and handle overflow
- Some 3rd-party applications (e.g. price feed scripts) may use the transaction builder functionality provided by cli_wallet without calling remove_builder_transaction, which may experience transaction handle overflow issues when running for a long time

abitmore added 2 commits

October 23, 2022 21:49


          Update default version of pts_address to constexpr

761aae4


          Update most functions of wallet_api class to const

40cc62c

abitmore added this to the 6.1.0 - Feature Release milestone

abitmore changed the base branch from fix-compiler-warnings to develop

October 24, 2022 00:07

abitmore added 11 commits

October 26, 2022 16:06


          Add comparator "std::less<>" to "map<string, ...>"

42c6afc


          Bump FC for std::map serialization update

7772d56


          Simplify help info in cli_wallet

0fd16c8


          Replace typedef with using

d417936


          Simplify wallet_api::borrow_asset() implementation

8fbc1cd


          Fix code smells

2d2bf9c


          Fix a long line

5f80313


          Bump FC for typename of map<K,V,std::less<>>

805e052


          Avoid using reserved identifier "remove"

c44e91c


          Rename a variable

d8090ca


          Extend transaction_handle_type to 32 bits

and handle overflow

sonarqubecloud bot commented Oct 27, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
18 Code Smells

65.8% Coverage
0.0% Duplication

abitmore merged commit 74d72ba into develop

abitmore deleted the fix-code-smells branch

October 27, 2022 22:46

abitmore mentioned this pull request

Draft Release Notes: BitShares Mekong 6.1.0 #2671

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet