filter out the price data that not have enough precision. #287
Conversation
Signed-off-by: kinglaw <58291@qq.com>
| b.close_base = trade_price.base.amount; | ||
| b.close_quote = trade_price.quote.amount; | ||
| if( b.high() < trade_price ) | ||
| if(trade_price.base.amount >= 100 && trade_price.quote.amount >= 100) |
There was a problem hiding this comment.
Although this is okay for most "popular" trading pairs, it's not ideal to be applied to all pairs, especially UIA's.
I think it's better that we record the data that how much difference is caused by rounding when matching orders, or simply record the "fair" price there, then process the data here.
merged from bitshares
|
Is this related to bitshares/bitshares-ui#200? |
|
The intent of this PR is unclear, but I think it is likely an attempt to fix that exact problem. |
|
@abitmore, is your PR related to bitshares/bitshares-ui#200? I am considering opening a new issue in the core for this because @svk31 thinks the issue goes deeper than the GUI and must be fixed in the core. He explains it here: bitshares/bitshares-ui#200 (comment). I don't want to create a duplicate issue, so I ask here first, but I am happy to open a new issue and link to the past discussions and relevant issues. The charts (long wicks mainly) and estimated account value are screwed up by these "fractional dust" trades executing out of range... it is a serious issue because we need good charts to get people to stay on the DEX. |
|
@landry314 it's not "my" PR. Please go ahead and create an issue. Better to discuss there. |
|
Please discuss in #449. |
|
Superseded by #455, closing this one. |
Signed-off-by: kinglaw 58291@qq.com