Rename option of debug witness plugin, fix #399

[abitmore]

This will get around #399.

[pmconrad]

Thinking about it - the --private-key option is a security risk. CLI options of running programs are visible to all users on the machine.
Perhaps with should remove to CLI option from both plugins and leave only the config file option?

[abitmore]

@pmconrad your suggestion makes sense, but perhaps better discuss it in a new ticket. At this moment we need the CLI parameter due to #149, and we need a usable release. This PR doesn't introduce additional risk.

[oxarbitrage]

i see no problem with this and after checking it out for a while i see no better option to go over #399 . i think we should merge to develop and close the issue with it.

[pmconrad]

Good. Thanks @abitmore !

[wackou]

Thinking about it - the --private-key option is a security risk. CLI options of running programs are visible to all users on the machine.
Perhaps with should remove to CLI option from both plugins and leave only the config file option?

Please don't, I agree with the assessment that it's a security risk, but it'd be better to document it this way (if not obvious already that, being a private key, you should be extra-careful where you use it), or even print a warning when used. I am using constantly (for automated deploys, etc. and pass all the options via the commandline) and it would be a pain for me to deal without it. Some other reasons that I think do not warrant removing it:

• having it in the config.ini doesn't really make it that more secure, you could argue that there's some unix user protection, but I'd counter argue that anyone having access to your machine, where gcc is most likely installed, can easily find a local privilege escalation, get root, and get to your file.
• it being a signing key, it is less critical to lose access to it than, say, your owner or active key

Thanks for reconsidering.